added part count and content range validation for download request #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
millems
reviewed
Aug 18, 2025
Comment on lines
+177
to
+184
| String actualContentRange = response.contentRange(); | ||
| if (actualContentRange != null && partSize == null) { | ||
| getRangeInfo(actualContentRange); | ||
| log.debug(() -> String.format("Part size of the object to download: " + partSize)); | ||
| log.debug(() -> String.format("Total Content Length of the object to download: " + totalContentLength)); | ||
| } | ||
|
|
||
| validateContentRange(totalComplete, actualContentRange); |
There was a problem hiding this comment.
It looks like there a race on the partSize and totalContentLength, since reading them is done outside of the lock. Or do we know that they won't change per part so it's safe?
Can you explain why it's safe to have multiple get object results modifying the part size and total content length in parallel before we do (again, potentially parallel) validation on them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For the part get request for S3 transfer manager, When a response is received, the S3 Transfer Manager MUST check the value of ContentRange and validate that it matches with the expected range for the specific part number. After all requests have been sent, we should validate that the total number of part GET requests sent matches with the expected PartsCount. This PR implements the validation.
Modifications
Added validation method in MultipartDownloaderSubscriber class
Testing
Added wiremock test for failed test
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License